RealNumberQ->RealValuedNumberQ #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - Thanks. |
|
Note that:
can all be reverted and adapted for the rename. |
|
Indeed, it is possible but I am not sure it is a good idea: since our Pattern matching routine is slow and has many flaws, I guess that the best (when is possible) is to use a generic BuiltinRule that dispatches the different cases. When we accomplish the task of fix the pattern matching code, then to revert this would be a relatively easy task. |
|
Ok, but please don't "fix" the pattern matching routine, especially via a largish PR. Let's discuss in more detail first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename this symbol for compatibility with the last version of WMA